lkml.org 
[lkml]   [2016]   [Jan]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] ASoC: mediatek: Enable 33bit memory address to support 4GB DRAM
On Mon, 11 Jan 2016 09:00:50 +0100,
PC Liao wrote:
>
> @@ -603,7 +606,10 @@ static int mtk_afe_dais_hw_params(struct snd_pcm_substream *substream,
> if (ret < 0)
> return ret;
>
> - memif->phys_buf_addr = substream->runtime->dma_addr;
> + if (sizeof(dma_addr_t) > 4)
> + msb_at_bit33 = (substream->runtime->dma_addr & 0x100000000) ? 1 : 0;

Better to put a proper suffix for the constant over 32bit.

Or use upper_32_bits(). Then sizeof() check can be omitted, as the
compiler should be smart enough to know it beforehand.


Takashi

\
 
 \ /
  Last update: 2016-01-11 10:21    [W:0.036 / U:0.412 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site