[lkml]   [2016]   [Jan]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH 3/3] ASoC: fsl_ssi: remove register defaults
Maciej S. Szmigiero wrote:
> There is no guarantee that on fsl_ssi module load
> SSI registers will have their power-on-reset values.
> In fact, if the driver is reloaded the values in
> registers will be whatever they were set to previously.
> This fixes hard lockup on fsl_ssi module reload,
> at least in AC'97 mode.
> Fixes: 05cf237972fe ("ASoC: fsl_ssi: Add driver suspend and resume to support MEGA Fast")
> Signed-off-by: Maciej S. Szmigiero<>

Acked-by: Timur Tabi <>

I'm surprised that we're actually encouraging drivers to contain
hard-coded register values.

 \ /
  Last update: 2016-01-10 23:01    [W:0.083 / U:0.040 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site