lkml.org 
[lkml]   [2015]   [Sep]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 6/7] selftests: only compile userfaultfd for x86 and powperpc
From
Date
On Tue, 2015-09-08 at 16:34 +0200, Andrea Arcangeli wrote:
>
> I already had a few minor changes queued to be submitted for arm and
> ppc and a few updates to the selftest.
>
> I didn't like that you had to remember running make headers_install
> for changes like the below one to build, so I added the dependency so
> that "make" still works without having to run other commands before
> it. These aren't reviewed yet.
>
> https://git.kernel.org/cgit/linux/kernel/git/andrea/aa.git/commit/?id=5ce2efeb91b501aa1bc7370f43732681fa9123e2

That's, how should I put it, fairly gross :)

I'd really rather you didn't do that. It's really not that hard to run make
headers_install once manually is it?

> I was planning to send these non-x86 updates to Andrew for review and
> merging...

Fine by me, that's probably the best way to get them in.

> Isn't this necessary as well?
>
> https://git.kernel.org/cgit/linux/kernel/git/andrea/aa.git/commit/?id=0eb943b76537a93fc4dd85cc0cbf937ce8266228

Yes, I think I acked that earlier today.

> I can include the below one too, but we need to coordinate to submit
> them or eventually some will reject.

I think given you already have a series you should pick this up as part of
that series. It will need to be reworked slightly anyway to go on top of your
series I think.

cheers




\
 
 \ /
  Last update: 2015-09-09 11:01    [W:0.363 / U:0.724 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site