Messages in this thread Patch in this message |  | | From | Rasmus Villemoes <> | Subject | [PATCH] PM / wakeup: wakeup_source_create: use kstrdup_const | Date | Wed, 9 Sep 2015 23:42:06 +0200 |
| |
Using kstrdup_const allows us to save a little runtime memory (and a string copy) in the common case where name is a string literal.
Signed-off-by: Rasmus Villemoes <linux@rasmusvillemoes.dk> --- drivers/base/power/wakeup.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/base/power/wakeup.c b/drivers/base/power/wakeup.c index 51f15bc15774..332e607e0030 100644 --- a/drivers/base/power/wakeup.c +++ b/drivers/base/power/wakeup.c @@ -91,7 +91,7 @@ struct wakeup_source *wakeup_source_create(const char *name) if (!ws) return NULL; - wakeup_source_prepare(ws, name ? kstrdup(name, GFP_KERNEL) : NULL); + wakeup_source_prepare(ws, name ? kstrdup_const(name, GFP_KERNEL) : NULL); return ws; } EXPORT_SYMBOL_GPL(wakeup_source_create); @@ -154,7 +154,7 @@ void wakeup_source_destroy(struct wakeup_source *ws) wakeup_source_drop(ws); wakeup_source_record(ws); - kfree(ws->name); + kfree_const(ws->name); kfree(ws); } EXPORT_SYMBOL_GPL(wakeup_source_destroy); -- 2.1.3
|  |