lkml.org 
[lkml]   [2015]   [Sep]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v3 06/17] staging: sm750fb: rename swI2CInit to sm750_sw_i2c_init
On Wed, Sep 09, 2015 at 11:41:20AM -0700, Greg Kroah-Hartman wrote:
> On Sun, Sep 06, 2015 at 09:17:56AM +0300, Mike Rapoport wrote:
> > Fix the checkpatch warning about CamelCase.
> >
> > Signed-off-by: Mike Rapoport <mike.rapoport@gmail.com>
> > ---
> > drivers/staging/sm750fb/ddk750_sii164.c | 2 +-
> > drivers/staging/sm750fb/ddk750_swi2c.c | 2 +-
> > drivers/staging/sm750fb/ddk750_swi2c.h | 2 +-
> > drivers/staging/sm750fb/sm750_hw.c | 2 +-
> > 4 files changed, 4 insertions(+), 4 deletions(-)
> >
> > diff --git a/drivers/staging/sm750fb/ddk750_sii164.c b/drivers/staging/sm750fb/ddk750_sii164.c
> > index 3d129aa..241b77b 100644
> > --- a/drivers/staging/sm750fb/ddk750_sii164.c
> > +++ b/drivers/staging/sm750fb/ddk750_sii164.c
> > @@ -132,7 +132,7 @@ long sii164InitChip(
> > /* Use fast mode. */
> > sm750_hw_i2c_init(1);
> > #else
> > - swI2CInit(DEFAULT_I2C_SCL, DEFAULT_I2C_SDA);
> > + sm750_sw_i2c_init(DEFAULT_I2C_SCL, DEFAULT_I2C_SDA);
>
> Hm, wait, "sw_"? what is the difference between the hw and sw versions?

As far as I understood, the intention for HW is for using i2c
controller, and SW is for using gpio bit-bang

--
Sincerely yours,
Mike.


\
 
 \ /
  Last update: 2015-09-09 22:21    [W:0.134 / U:2.584 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site