lkml.org 
[lkml]   [2015]   [Sep]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2] of_pci_irq: Silence bogus "of_irq_parse_pci() failed ..." messages.
On 09/09/2015 10:44 AM, Frank Rowand wrote:
> Second attempt at this reply. The first reply was mangled.
>
> On 9/8/2015 11:28 AM, David Daney wrote:
>> From: David Daney <david.daney@cavium.com>
>>
>> It is perfectly legitimate for a PCI device to have an
>> PCI_INTERRUPT_PIN value of zero. This happens if the device doesn't
>> use interrupts, or on PCIe devices, where only MSI/MSI-X are
>> supported.
>>
>> Silence the annoying "of_irq_parse_pci() failed with rc=-19" error
>> messages by moving the printing code into of_irq_parse_pci(), and only
>> emitting the message for cases where PCI_INTERRUPT_PIN == 0 is not the
>> cause for an early exit.
>>
>> Signed-off-by: David Daney <david.daney@cavium.com>
>> ---
>> Changes in v2: Move the print function in to of_irq_parse_pci() at a
>> common error exit point (as suggested by Frank Rowand).
>>
>>
[...]
>> @@ -87,6 +89,9 @@ int of_irq_parse_pci(const struct pci_dev *pdev, struct of_phandle_args *out_irq
>> laddr[0] = cpu_to_be32((pdev->bus->number << 16) | (pdev->devfn << 8));
>> laddr[1] = laddr[2] = cpu_to_be32(0);
>
>> return of_irq_parse_raw(laddr, out_irq);
>
> should be:
>
> rc = of_irq_parse_raw(laddr, out_irq);
> if (rc)
> goto err;
> return 0;
>

You are right. I will send v3.

Thanks,
David Daney

>> +err:
>> + dev_err(&pdev->dev, "of_irq_parse_pci() failed with rc=%d\n", rc);
>> + return rc;



\
 
 \ /
  Last update: 2015-09-09 20:21    [W:0.037 / U:9.988 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site