lkml.org 
[lkml]   [2015]   [Sep]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH V9 0/6] Freq/CPU%/CORE_BUSY% support
On Tue, Sep 08, 2015 at 03:32:43PM -0400, kan.liang@intel.com wrote:
> From: Kan Liang <kan.liang@intel.com>
>
> This patch set supports per-sample freq/CPU%/CORE_BUSY% print in perf
> report.
> For printing these information, the perf.data file must have been obtained
> by group read and using special events cycles, ref-cycles, msr/tsc/,
> msr/aperf/ or msr/mperf/.
>
> - Freq (MHz): The frequency during the sample interval. Needs cycles
> ref-cycles event.
> - CPU%: CPU utilization during the sample interval. Needs ref-cycles and
> msr/tsc/ events.
> - CORE_BUSY%: actual percent performance (APERF/MPERF%) during the
> sample interval. Needs msr/aperf/ and msr/mperf/ events.
>
> Here is an example:
>
> $ perf record --freq-perf ~/tchain_edit
>
> $ perf report --stdio --freq-perf
>
> Overhead FREQ MHz CPU% CORE_BUSY%
> Command Shared Object Symbol
> ........................................ ......... ..... ..........
> ........... ................ ......................
>
> 99.54% 99.54% 99.53% 99.53% 99.53% 2301 96 99
> tchain_edit tchain_edit [.] f3
> 0.20% 0.20% 0.20% 0.20% 0.20% 2301 98 99
> tchain_edit tchain_edit [.] f2
> 0.05% 0.05% 0.05% 0.05% 0.05% 2300 98 99
> tchain_edit [kernel.vmlinux] [k] read_tsc
>
> Changes since V1:
> - Save cpu max freq to header when recording
> - Read cpu max freq and msr type from header when reporting
>
> Changes since V2:
> - Introduce generic FEAT for CPU related data stored
> - Make cpu max freq and msr type part of perf_session_env
> - rename cpu_u to cpu_util
> - Don't save sample value in perf_sample and discards new iterator.
> Calculating the freq_perf_info in add_entry_cb callback
> - Introduce symbol_conf.freq_perf_type for related hpp column visibility
>
> Changes since V3:
> - add a identifier 'tag' for CPU attributes, max frequency.
> - add backpointers to evlist for env, and evsel for evlist.
> - Use bitmask for freq_perf_type
> - Replace macros by functions to caculate freq, cpu_util and core_busy
> - Move all caculation codes under symbol_conf.show_freq_perf condition.
>
> Changes since V4:
> - Store cpu attributes id as tag and more readable cpu_attr
>
> Changes since V5:
> - Rename freq to max_freq and use it
> - Add a loop in process_cpu_attributes to facility future extension
>
> Changes since V6:
> - Split rename perf_session_env and add backpointer to evlist patches
>
> Changes since V7:
> - Introduce --freq-perf option for perf record
> - Factor out fix for dump_sample
>
> Changes since V8:
> - Rename --show-freq-perf to --freq-perf
> - --freq-perf option imply --group

I believe I just acked all of it but the last one,
otherwise I'm ok with it

thanks,
jirka


\
 
 \ /
  Last update: 2015-09-09 17:01    [W:0.196 / U:2.632 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site