[lkml]   [2015]   [Sep]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH 0/5] Add eeprom to the Olimex series of boards

On 09-09-15 16:05, Maxime Ripard wrote:
> On Wed, Sep 09, 2015 at 11:25:10AM +0200, Olliver Schinagl wrote:
>> Some of the olimex series of boards feature a permanently connected eeprom on
>> i2c-1. This patch series adds them on all the boards that have them according
>> to the spec-sheets.
>> I explicitly added my personal --Tested-by to boards I actually tested.
> Testing your changes is the strict minimum before testing your
> patches. Just like running checkpatch on them, which you clearly
> failed to do, otherwise you would have seen that this is not the right
> syntax. Drop the tested-by, fix your SoB.
Actually, I did run check-patch and it complained about the format, but
it was the same as when outputted with a git -s. I obviously missed
something there! So I double check that. I will resubmit without a
tested-by for the boards I did test it on.
>> There are two boards, that according to the sheets have them as well
>> and physically inspecting the boards shows them clearly, I did not
>> actually test them on those the boards that are missing the
>> --Tested-by.
> Then don't send those patches.
I put them out there so someone could pick up on that with the least
amount of effort. I will drop them
> Maxime

Met vriendelijke groeten, Kind regards, 与亲切的问候

Olliver Schinagl
Research & Development
Ultimaker B.V.

 \ /
  Last update: 2015-09-09 16:41    [W:0.063 / U:0.188 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site