lkml.org 
[lkml]   [2015]   [Sep]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] lib/vsprintf.c: increase the size of the field_width variable
On Wed, Sep 09, 2015 at 12:13:10PM +0200, Maurizio Lombardi wrote:
> When printing a bitmap using the "%*pb[l]" printk format
> a 16 bit variable (field_width) is used to store the size of the bitmap.
> In some cases 16 bits are not sufficient, the variable overflows and
> printk does not work as expected.
>
> This patch fixes the problem by changing the type of field_width to s32.
>
> How to reproduce the bug:
>
> 1.load scsi_debug
> # modprobe scsi-debug dev_size_mb=256 lbpu=1 lbpws10=1
>
> 2.create VG
> # vgcreate tsvg /dev/sdb
> Physical volume "/dev/sdb" successfully created
> Volume group "tsvg" successfully created
>
> 3. Bitmap should be set, but still empty
> # cat /sys/bus/pseudo/drivers/scsi_debug/map
>
> Expected results:
> # cat /sys/bus/pseudo/drivers/scsi_debug/map
> 0-15
>
> Signed-off-by: Maurizio Lombardi <mlombard@redhat.com>

Acked-by: Tejun Heo <tj@kernel.org>

Thanks.

--
tejun


\
 
 \ /
  Last update: 2015-09-09 16:01    [W:0.105 / U:6.080 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site