Messages in this thread |  | | Date | Tue, 8 Sep 2015 10:41:30 -0700 | Subject | Re: [PATCH 3/3] Revert "task_work: remove fifo ordering guarantee" | From | Linus Torvalds <> |
| |
On Tue, Sep 8, 2015 at 10:39 AM, Linus Torvalds <torvalds@linux-foundation.org> wrote: > > The other patches I do like - why add those list operations that are > just guaranteed to mess up the cache to add the file descriptors to > the workqueue list, when we can just do the operation directly?
Side note, it's not just messing with the cache unnecessarily when the lists grow long, the "cmpxchg" involved in adding the work is fairly expensive. It may be an unlocked operation, but it's generally as expensive as a locked one - just without the possibility of a deadlock.
Linus
|  |