Messages in this thread |  | | Date | Tue, 8 Sep 2015 12:18:27 -0300 | Subject | Re: [PATCH 3/3] arm64: dts: mt8173: Add nor flash node | From | Ezequiel Garcia <> |
| |
On 8 September 2015 at 08:53, Jagan Teki <jteki@openedev.com> wrote: > On 8 September 2015 at 15:19, Bayi Cheng <bayi.cheng@mediatek.com> wrote: >> Add Mediatek nor flash node >> >> Signed-off-by: Bayi Cheng <bayi.cheng@mediatek.com> >> --- >> arch/arm64/boot/dts/mediatek/mt8173.dtsi | 10 ++++++++++ >> 1 file changed, 10 insertions(+) >> >> diff --git a/arch/arm64/boot/dts/mediatek/mt8173.dtsi b/arch/arm64/boot/dts/mediatek/mt8173.dtsi >> index d18ee42..a14f005 100644 >> --- a/arch/arm64/boot/dts/mediatek/mt8173.dtsi >> +++ b/arch/arm64/boot/dts/mediatek/mt8173.dtsi >> @@ -365,6 +365,16 @@ >> status = "disabled"; >> }; >> >> + nor_flash: nor@1100d000 { > > Based on the comments from 1/3 - this notation needs to be change something like > qspi0: quadspi@1100d000 >
Actually, to follow ePAPR recomendations it should be named as flash@1100d000. (See ePAPR, 2.2.2 Generic Names Recommendation).
I believe the phandle name choice can be more descriptive. -- Ezequiel García, VanguardiaSur www.vanguardiasur.com.ar
|  |