[lkml]   [2015]   [Sep]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH] toshiba_acpi: Fix hotkeys registration on some toshiba models
On Wed, Sep 09, 2015 at 11:25:45AM -0600, Azael Avalos wrote:
> Commit a2b3471b5b13 ("toshiba_acpi: Use the Hotkey Event Type function
> for keymap choosing") changed the *setup_keyboard function to query for
> the Hotkey Event Type to help choose the correct keymap, but turns out
> that here are certain Toshiba models out there not implementing this
> feature, and thus, failing to continue the input device registration and
> leaving such laptops without hotkey support.
> This patch changes such check, and instead of returning an error if
> the Hotkey Event Type is not present, we simply inform userspace about it,
> changing the message printed from err to notice, making the function
> responsible for registering the input device to continue.
> This issue was found on a Toshiba Portege Z30-B, but there might be
> some other models out there affected by this regression as well.
> Cc: <> # 4.1+
> Signed-off-by: Azael Avalos <>

Queued for 4.3, thanks!

Darren Hart
Intel Open Source Technology Center

 \ /
  Last update: 2015-09-10 18:41    [W:0.065 / U:5.332 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site