[lkml]   [2015]   [Sep]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH] lib/vsprintf.c: increase the size of the field_width variable

On 09/10/2015 09:38 AM, Joe Perches wrote:ing will be printed.
> Maurizio, did you try the patch I posted?
> I think it'll work, but it doesn't fix the
> fundamental issue of %*pbl with large bitmaps.

I tested your patch, it works for the simple cases where bits are set
below the S16_MAX limit, example:

# modprobe scsi-debug dev_size_mb=256 lbpu=1 lbpws10=1
# vgcreate tsvg /dev/sdb
# cat /sys/bus/pseudo/drivers/scsi_debug/map
0-15 <--- OK!

# lvcreate -V200m -l99%FREE -T tsvg/pool -n lv1 --discards ignore

# cat /sys/bus/pseudo/drivers/scsi_debug/map
0-31,2048-2055 <---- NO! It should be "0-31,2048-2055,501760-501871"!

I think it's misleading.
Can I suggest as a temporary solution to restore the old
bitmap_scnlistprintf() function?

> Perhaps the thin wrapper conversions in lib/bitmap.c
> in that commit for bitmap_scnprintf, bscnl_emit, and
> bitmap_scnlistprintf should be reverted.

Maurizio Lombardi

 \ /
  Last update: 2015-09-10 11:01    [W:0.110 / U:2.036 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site