Messages in this thread |  | | From | Rasmus Villemoes <> | Subject | Re: [PATCH] x86: wmi: Remove private %pUL implementation | Date | Tue, 12 May 2015 14:06:27 +0200 |
| |
On Fri, Mar 06 2015, Darren Hart <dvhart@infradead.org> wrote:
> On Tue, Feb 24, 2015 at 03:15:30PM +0100, Rasmus Villemoes wrote: >> The work performed by wmi_gtoa is equivalent to simply sprintf(out, >> "%pUL", in), so one could replace its body by this. However, most >> users feed the result directly as a %s argument to some other function >> which also understands the %p extensions (they all ultimately use >> vsnprintf), so we can eliminate some stack buffers and quite a bit of >> code by just using %pUL directly. >> >> In wmi_dev_uevent I'm not sure whether there's room for a >> nul-terminator in env->buf, so I've just replaced wmi_gtoa with the >> equivalent sprintf call. >> >> Signed-off-by: Rasmus Villemoes <linux@rasmusvillemoes.dk> > > Nice cleanup, thanks Rasmus. Queued for 4.1.
Hi Darren
This seems to have fallen through the cracks - I don't see it in 4.1-rc3.
Rasmus
|  |