[lkml]   [2015]   [May]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH] x86: wmi: Remove private %pUL implementation
On Fri, Mar 06 2015, Darren Hart <> wrote:

> On Tue, Feb 24, 2015 at 03:15:30PM +0100, Rasmus Villemoes wrote:
>> The work performed by wmi_gtoa is equivalent to simply sprintf(out,
>> "%pUL", in), so one could replace its body by this. However, most
>> users feed the result directly as a %s argument to some other function
>> which also understands the %p extensions (they all ultimately use
>> vsnprintf), so we can eliminate some stack buffers and quite a bit of
>> code by just using %pUL directly.
>> In wmi_dev_uevent I'm not sure whether there's room for a
>> nul-terminator in env->buf, so I've just replaced wmi_gtoa with the
>> equivalent sprintf call.
>> Signed-off-by: Rasmus Villemoes <>
> Nice cleanup, thanks Rasmus. Queued for 4.1.

Hi Darren

This seems to have fallen through the cracks - I don't see it in


 \ /
  Last update: 2015-05-12 14:41    [W:0.107 / U:0.512 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site