[lkml]   [2015]   [Apr]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
Patch in this message
Subject[PATCH 6/7] block: replace trylock with mutex_lock in blkdev_reread_part()
From: Ming Lei <>

The only possible problem of using mutex_lock() instead of trylock
is about deadlock.

If there aren't any locks held before calling blkdev_reread_part(lock),
deadlock can't be caused by this conversion.

If there are locks held before calling blkdev_reread_part(lock),
and if these locks arn't required in open, close handler and I/O
path, deadlock shouldn't be caused too.

Both user space's ioctl(BLKRRPART) and md_setup_drive() from
init/do_mounts_md.c belongs to the 1st case, so the conversion is safe
for the two cases.

For loop, the previous patches in this pathset has fixed the ABBA lock
dependency, so the conversion is OK.

For nbd, tx_lock is held when calling the function:

- both open and release won't hold the lock
- when blkdev_reread_part() is run, I/O thread has been stopped
already, so tx_lock won't be acquired in I/O path at that time.
- so the conversion won't cause deadlock for nbd

For dasd, both dasd_open(), dasd_release() and request function don't
acquire any mutex/semphone, so the conversion should be safe.

[jarod: update for modifications earlier in series.]

CC: Christoph Hellwig <>
CC: Jens Axboe <>
CC: Tejun Heo <>
CC: Alexander Viro <>
CC: Markus Pargmann <>
CC: Stefan Weinhuber <>
CC: Stefan Haberland <>
CC: Sebastian Ott <>
CC: Fabian Frederick <>
CC: Ming Lei <>
CC: David Herrmann <>
CC: Mike Galbraith <>
CC: Andrew Morton <>
CC: Peter Zijlstra <>
Signed-off-by: Ming Lei <>
Signed-off-by: Jarod Wilson <>
block/ioctl.c | 12 ++++++++----
1 file changed, 8 insertions(+), 4 deletions(-)

diff --git a/block/ioctl.c b/block/ioctl.c
index 64a4fcb..47c8e6d 100644
--- a/block/ioctl.c
+++ b/block/ioctl.c
@@ -170,15 +170,19 @@ EXPORT_SYMBOL(__blkdev_reread_part);

* This is an exported API for the block driver, and will
- * acquire bd_mutex. Make sure you aren't calling it with
- * bd_mutex already held, or we'll return -EBUSY.
+ * acquire bd_mutex.
+ *
+ * Make sure held locks aren't required in open()/close()
+ * handlers and I/O paths to avoid an ABBA deadlock:
+ * - bd_mutex is held before calling a block driver's open/close
+ * handler
+ * - reading a partition table may submit I/O to the block device
int blkdev_reread_part(struct block_device *bdev)
int res;

- if (!mutex_trylock(&bdev->bd_mutex))
- return -EBUSY;
+ mutex_lock(&bdev->bd_mutex);
res = __blkdev_reread_part(bdev);


 \ /
  Last update: 2015-04-08 09:01    [W:0.688 / U:0.136 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site