lkml.org 
[lkml]   [2015]   [Apr]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 3/16] [media] radio: fix error return code
    Date
    Return a negative error code on failure.

    A simplified version of the semantic match that finds this problem is as
    follows: (http://coccinelle.lip6.fr/)

    // <smpl>
    @@
    identifier ret; expression e1,e2;
    @@
    (
    if (\(ret < 0\|ret != 0\))
    { ... return ret; }
    |
    ret = 0
    )
    ... when != ret = e1
    when != &ret
    *if(...)
    {
    ... when != ret = e2
    when forall
    return ret;
    }
    // </smpl>

    Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>

    ---
    drivers/media/radio/radio-timb.c | 4 +++-
    1 file changed, 3 insertions(+), 1 deletion(-)

    diff --git a/drivers/media/radio/radio-timb.c b/drivers/media/radio/radio-timb.c
    index e6b55ed..04baafe 100644
    --- a/drivers/media/radio/radio-timb.c
    +++ b/drivers/media/radio/radio-timb.c
    @@ -138,8 +138,10 @@ static int timbradio_probe(struct platform_device *pdev)
    i2c_get_adapter(pdata->i2c_adapter), pdata->tuner, NULL);
    tr->sd_dsp = v4l2_i2c_new_subdev_board(&tr->v4l2_dev,
    i2c_get_adapter(pdata->i2c_adapter), pdata->dsp, NULL);
    - if (tr->sd_tuner == NULL || tr->sd_dsp == NULL)
    + if (tr->sd_tuner == NULL || tr->sd_dsp == NULL) {
    + err = -ENODEV;
    goto err_video_req;
    + }

    tr->v4l2_dev.ctrl_handler = tr->sd_dsp->ctrl_handler;



    \
     
     \ /
      Last update: 2015-04-05 14:21    [W:7.636 / U:0.004 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site