lkml.org 
[lkml]   [2015]   [Apr]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 9/16] HID: logitech-hidpp: fix error return code
    Date
    Return a negative error code on failure.

    A simplified version of the semantic match that finds this problem is as
    follows: (http://coccinelle.lip6.fr/)

    // <smpl>
    @@
    identifier ret; expression e1,e2;
    @@
    (
    if (\(ret < 0\|ret != 0\))
    { ... return ret; }
    |
    ret = 0
    )
    ... when != ret = e1
    when != &ret
    *if(...)
    {
    ... when != ret = e2
    when forall
    return ret;
    }
    // </smpl>

    Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>

    ---
    drivers/hid/hid-logitech-hidpp.c | 1 +
    1 file changed, 1 insertion(+)

    diff --git a/drivers/hid/hid-logitech-hidpp.c b/drivers/hid/hid-logitech-hidpp.c
    index e77658c..ce9819f 100644
    --- a/drivers/hid/hid-logitech-hidpp.c
    +++ b/drivers/hid/hid-logitech-hidpp.c
    @@ -1210,6 +1210,7 @@ static int hidpp_probe(struct hid_device *hdev, const struct hid_device_id *id)
    connected = hidpp_is_connected(hidpp);
    if (id->group != HID_GROUP_LOGITECH_DJ_DEVICE) {
    if (!connected) {
    + ret = -ENODEV;
    hid_err(hdev, "Device not connected");
    hid_device_io_stop(hdev);
    goto hid_parse_fail;


    \
     
     \ /
      Last update: 2015-04-05 14:21    [W:4.818 / U:0.092 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site