lkml.org 
[lkml]   [2015]   [Apr]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    SubjectRe: [PATCH 9/9] sound/ppc/snd_ps3.c: fix error return code
    From
    On Sun, Apr 5, 2015 at 1:38 PM, Julia Lawall <Julia.Lawall@lip6.fr> wrote:
    > From: Julia Lawall <Julia.Lawall@lip6.fr>
    >
    > Initialize ret before returning on failure, as done elsewhere in the
    > function.

    > diff --git a/sound/ppc/snd_ps3.c b/sound/ppc/snd_ps3.c
    > index 1aa52ef..9b18b52 100644
    > --- a/sound/ppc/snd_ps3.c
    > +++ b/sound/ppc/snd_ps3.c
    > @@ -1040,6 +1040,7 @@ static int __devinit snd_ps3_driver_probe(struct ps3_system_bus_device *dev)
    > GFP_KERNEL);
    > if (!the_card.null_buffer_start_vaddr) {
    > pr_info("%s: nullbuffer alloc failed\n", __func__);
    > + ret = -ENOMEM;
    > goto clean_preallocate;
    > }
    > pr_debug("%s: null vaddr=%p dma=%#llx\n", __func__,

    This has already been applied in 2012?

    commit c86b93628e5649fd7bb0574b570a51b2b02d586c
    Author: Julia Lawall <Julia.Lawall@lip6.fr>
    AuthorDate: Sun Aug 19 09:02:59 2012 +0200
    Commit: Takashi Iwai <tiwai@suse.de>
    CommitDate: Mon Aug 20 11:01:14 2012 +0200

    ALSA: sound/ppc/snd_ps3.c: fix error return code

    Gr{oetje,eeting}s,

    Geert

    --
    Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

    In personal conversations with technical people, I call myself a hacker. But
    when I'm talking to journalists I just say "programmer" or something like that.
    -- Linus Torvalds


    \
     
     \ /
      Last update: 2015-04-05 14:21    [W:6.969 / U:0.016 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site