lkml.org 
[lkml]   [2015]   [Apr]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH/RFC 5/6] staging: board: Add support for devices with complex dependencies
Date
Hi Geert,

On Sunday 05 April 2015 11:00:56 Geert Uytterhoeven wrote:
> On Sat, Apr 4, 2015 at 2:46 PM, Laurent Pinchart wrote:
> >> + for (i = 0; i < dev->ngpios; i++)
> >> + gpio_request_one(dev->gpios[i].gpio, dev->gpios[i].flags,
> >> + pdev->name);
> >
> > Aren't GPIO numbers dynamic too in DT-based systems ? Beside, shouldn't it
> > be
>
> Apparently not, as the old legacy number still works, and it doesn't work
> without.

I think we're just lucky there that the SoC main GPIO controller gets
registered first and starts counting GPIOs with a zero offset.

> > the responsibility of the drievr to request the GPIOs it needs ?
>
> As far as I understand it, on Armadillo this is used more for platform
> configuration than for device configuration, as it affects multiple devices
> (the comment says DBGMD/LCDC0/FSIA MUX).
>
> I guess I could use a "gpio-hog" subnode in DT instead, but then we're
> already implementing the conversion to DT ;-)

But that's the goal :-) I'd rather move GPIO and pinctrl to DT directly as we
already have the infrastructure to do so.

--
Regards,

Laurent Pinchart



\
 
 \ /
  Last update: 2015-04-05 22:41    [W:0.356 / U:0.012 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site