lkml.org 
[lkml]   [2015]   [Apr]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] usb: musb: Kconfig: Depend on some machines under blackfin
On Sat, Apr 04, 2015 at 05:51:21AM +0800, Chen Gang wrote:
> Under blackfin, only bf527, bf548 and bf609 may use musb. The related
> error with allmodconfig:
>
> CC [M] drivers/usb/misc/trancevibrator.o
> In file included from drivers/usb/musb/musb_core.h:70:0,
> from drivers/usb/musb/musb_core.c:103:
> drivers/usb/musb/musb_core.c: In function 'musb_indexed_ep_select':
> drivers/usb/musb/musb_regs.h:458:32: error: 'USB_INDEX' undeclared (first use in this function)
> #define MUSB_INDEX USB_OFFSET(USB_INDEX) /* 8 bit */
> ^
>
> Signed-off-by: Chen Gang <gang.chen.5i5j@gmail.com>

Why not fix the root cause and provide this symbol on blackfin? There's
no specific reason why it shouldn't be able to be built on this
platform.

It's better to make platforms properly build everything, patches like
this just make things messier and harder to maintain.

thanks,

greg k-h


\
 
 \ /
  Last update: 2015-04-04 12:21    [W:0.152 / U:5.120 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site