[lkml]   [2015]   [Apr]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
    SubjectRe: Re: msgrcv: use freezable blocking call
    On Wed, Apr 01, 2015 at 05:18:46AM +0000, Maninder Singh wrote:
    > Hi Andrew,
    > Thanks for making new patch, Actually there is some problem with our mail editor.
    > It changes tabs with spaces and corrupts the patch, we are solving the same at our end.
    > Thats why i am sending you signed -off by only for both patches.

    Sort it and resend, no real great hurry with these patches, right?

    > 1. For msgrcv: use freezable blocking call
    > Signed-off-by: Yogesh Gaur <>
    > Signed-off-by: Maninder Singh <>
    > Signed-off-by: Manjeet Pawar <>

    Did you really pass around that patch through 3 people or did it take
    all three of you to modify those two lines?

    Should some of those SoBs be a reviewed-by perhaps?

    > ----> For Peter's Review comment:- This is what, no why mentioned
    > This call was selected to be converted to a freezable call because
    > it doesn't hold any locks or release any resources when interrupted
    > that might be needed by another freezing task or a kernel driver
    > during suspend, and is a common site where idle userspace tasks are
    > blocked.

    Please put such things in the Changelog so that we can see you've
    thought about things.

     \ /
      Last update: 2015-04-01 10:01    [W:8.294 / U:0.624 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site