lkml.org 
[lkml]   [2015]   [Apr]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
From
Subject[PATCH] thermal: user_space: add trip point number to uevent data
Date
A user-space thermal governor does not currently know which trip point
caused a uevent to trigger. Let's add this information to the payload.

This is just an RFC, because this patch (on its own) is not very useful.
The only current caller of the .throttle callback is in
thermal_zone_device_update(), which loops over *all* trip points. This
seems very counter-intuitive and unhelpful, but maybe I'm just clueless.

Signed-off-by: Brian Norris <computersforpeace@gmail.com>
---
drivers/thermal/user_space.c | 13 ++++++++++++-
1 file changed, 12 insertions(+), 1 deletion(-)

diff --git a/drivers/thermal/user_space.c b/drivers/thermal/user_space.c
index 10adcddc8821..9fc03d3271d6 100644
--- a/drivers/thermal/user_space.c
+++ b/drivers/thermal/user_space.c
@@ -22,6 +22,8 @@
* ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
*/

+#include <linux/kernel.h>
+#include <linux/slab.h>
#include <linux/thermal.h>

#include "thermal_core.h"
@@ -34,9 +36,18 @@
*/
static int notify_user_space(struct thermal_zone_device *tz, int trip)
{
+ char *envp[] = { NULL, NULL };
+
+ envp[0] = kasprintf(GFP_KERNEL, "TRIPNUM=%u", trip);
+ if (!envp[0])
+ return -ENOMEM;
+
mutex_lock(&tz->lock);
- kobject_uevent(&tz->device.kobj, KOBJ_CHANGE);
+ kobject_uevent_env(&tz->device.kobj, KOBJ_CHANGE, envp);
mutex_unlock(&tz->lock);
+
+ kfree(envp[0]);
+
return 0;
}

--
1.9.1


\
 
 \ /
  Last update: 2015-04-02 03:21    [W:0.028 / U:0.532 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site