[lkml]   [2015]   [Apr]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH 2/4] perf tools: introduce machine_map_new to merge mmap/mmap2 processing code.
Em Wed, Apr 01, 2015 at 02:18:53PM +0200, Jiri Olsa escreveu:
> On Wed, Apr 01, 2015 at 10:33:13AM +0000, Wang Nan wrote:
> > Create a machine_map_new() and merge mapping code in
> > machine__process_mmap2_event() and machine__process_mmap_event()
> > together. This patch is a preparation for following map adjustment
> > patches.

> > diff --git a/tools/perf/util/machine.c b/tools/perf/util/machine.c

> > +static int machine_map_new(struct machine *machine, u64 start, u64 len,
> > + u64 pgoff, u32 pid, u32 d_maj, u32 d_min, u64 ino,
> > + u64 ino_gen, u32 prot, u32 flags, char *filename,
> > + enum map_type type, struct thread *thread)

> the name style for this should be more like 'machine__new_map'
> I think Arnaldo will chime in.. ;-)

Right, I wonder if this is a function that is about 'maps' or 'machines'
mostly, that would say what prefix should be used, if map__ or
machine__, still need to review this patchset.

Just give a really quick lock, eyebrows raised, even more complexity for
the symbol layer, wonder if this can't be simplified...

- Arnaldo

 \ /
  Last update: 2015-04-01 17:21    [W:0.069 / U:0.368 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site