lkml.org 
[lkml]   [2015]   [Apr]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v2 4/4] Add virtio-vga bits.
From
Date
On Mi, 2015-04-01 at 15:26 +0200, Michael S. Tsirkin wrote:
> On Wed, Apr 01, 2015 at 03:15:30PM +0200, Gerd Hoffmann wrote:
> > +static void virtio_pci_kick_out_firmware_fb(struct pci_dev *pci_dev)
> > +{
> > + struct apertures_struct *ap;
> > + bool primary;
> > +
> > + ap = alloc_apertures(1);
> > + if (!ap)
> > + return;
> > +
> > + ap->ranges[0].base = pci_resource_start(pci_dev, 2);
> > + ap->ranges[0].size = pci_resource_len(pci_dev, 2);
>
> I thought you mentioned it's better to switch to a different BAR
> to be compatible with stdvga?

Indeed, thats why the cover letter lists this as todo item, because it
isn't sorted yet.

Need to figure a sane way to handle this on the host side. Current plan
is trying to make virtio_pci_device_plugged() configurable without
making things too messy.

cheers,
Gerd




\
 
 \ /
  Last update: 2015-04-01 16:21    [W:0.039 / U:0.524 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site