lkml.org 
[lkml]   [2015]   [Apr]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH perf/core 2/2] perf-probe: Check the orphaned -x option
    On Wed, Apr 01, 2015 at 07:25:42PM +0900, Masami Hiramatsu wrote:
    > To avoid probing in unintended binary, the orphaned -x option
    > must be checked and warned.
    >
    > Without this patch, following command sets up the probe in
    > the kernel.
    > -----
    > # perf probe -a strcpy -x ./perf
    > Added new event:
    > probe:strcpy (on strcpy)
    >
    > You can now use it in all perf tools, such as:
    >
    > perf record -e probe:strcpy -aR sleep 1
    > -----
    >
    > But in this case, it seems that the user may want to probe
    > in the perf binary. With this patch, perf-probe correctly
    > handles the orphaned -x.
    > -----
    > # perf probe -a strcpy -x ./perf
    > Error: -x/-m must follow the probe definitions.
    > ...
    > -----
    >
    > Reported-by: Jiri Olsa <jolsa@redhat.com>

    works nicely, thanks a lot!

    Tested-by: Jiri Olsa <jolsa@kernel.org>

    jirka


    \
     
     \ /
      Last update: 2015-04-01 13:41    [W:9.458 / U:0.008 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site