lkml.org 
[lkml]   [2015]   [Apr]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
From
Subject[PATCH] usb: gadget: ffs: don't allow to open with O_NONBLOCK flag
Date
FunctionFS can't support O_NONBLOCK because read/write operatons are
directly translated into USB requests which are asynchoronous, so we
can't know how long we will have to wait for request completion. For
this reason in case of open with O_NONBLOCK flag we return -EWOULDBLOCK.

Signed-off-by: Robert Baldyga <r.baldyga@samsung.com>
---
drivers/usb/gadget/function/f_fs.c | 16 ++++++++++++++++
1 file changed, 16 insertions(+)

diff --git a/drivers/usb/gadget/function/f_fs.c b/drivers/usb/gadget/function/f_fs.c
index 175c995..1014911 100644
--- a/drivers/usb/gadget/function/f_fs.c
+++ b/drivers/usb/gadget/function/f_fs.c
@@ -538,6 +538,14 @@ static int ffs_ep0_open(struct inode *inode, struct file *file)
if (unlikely(ffs->state == FFS_CLOSING))
return -EBUSY;

+ /*
+ * We are not supporting O_NONBLOCK because read/write operatons are
+ * directly translated into USB requests which are asynchoronous, so
+ * we can't know how long we will have to wait for request completion.
+ */
+ if (unlikely(file->f_flags & O_NONBLOCK))
+ return -EWOULDBLOCK;
+
file->private_data = ffs;
ffs_data_opened(ffs);

@@ -874,6 +882,14 @@ ffs_epfile_open(struct inode *inode, struct file *file)
if (WARN_ON(epfile->ffs->state != FFS_ACTIVE))
return -ENODEV;

+ /*
+ * We are not supporting O_NONBLOCK because read/write operatons are
+ * directly translated into USB requests which are asynchoronous, so
+ * we can't know how long we will have to wait for request completion.
+ */
+ if (unlikely(file->f_flags & O_NONBLOCK))
+ return -EWOULDBLOCK;
+
file->private_data = epfile;
ffs_data_opened(epfile->ffs);

--
1.9.1


\
 
 \ /
  Last update: 2015-04-01 12:21    [W:0.045 / U:0.104 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site