lkml.org 
[lkml]   [2015]   [Mar]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 2/9] selftests: Add install target
On 03/09/2015 08:20 AM, Shuah Khan wrote:
> On 03/05/2015 11:53 AM, Dave Jones wrote:
>> On Tue, Mar 03, 2015 at 03:51:35PM +1100, Michael Ellerman wrote:
>> > This adds make install support to selftests. The basic usage is:
>> >
>> > $ cd tools/testing/selftests
>> > $ make install
>> >
>> > That installs into tools/testing/selftests/install, which can then be
>> > copied where ever necessary.
>> >
>> > The install destination is also configurable using eg:
>> >
>> > $ INSTALL_PATH=/mnt/selftests make install
>>
>> ...
>>
>> > + @# Ask all targets to emit their test scripts
>> > + echo "#!/bin/bash\n\n" > $(ALL_SCRIPT)
>>
>> $ ./all.sh
>> -bash: ./all.sh: /bin/bash\n\n: bad interpreter: No such file or directory
>>
>> Removing the \n\n fixes it.
>>
>> > + echo "cd \$$ROOT\n" >> $(ALL_SCRIPT); \
>>
>> ditto
>>
>> Dave
>
> Michael,
>
> Could you please fix these problems and send the patch.
>

Michael,

Did you happen to run run_kselftest.sh from the install
directory to make sure all the dependent executables
are installed? You are missing a few required dependencies.
efivars test for example.

Please run kselftest_install.sh I sent out for review and
compare the following:

- contents of install directory created with your patch vs.
my kselftest_install.sh tool
- Compare your run_kselftest.sh run with the one that gets
generated with my kselftest_install.sh tool

General rule is all tests that get run when run_tests target
is run should run from the install directory using the
run_kselftest.sh generated during install.

thanks,
-- Shuah

--
Shuah Khan
Sr. Linux Kernel Developer
Open Source Innovation Group
Samsung Research America (Silicon Valley)
shuahkh@osg.samsung.com | (970) 217-8978


\
 
 \ /
  Last update: 2015-03-09 23:41    [W:0.092 / U:28.180 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site