lkml.org 
[lkml]   [2015]   [Mar]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH 1/1] x86/fpu: math_state_restore() should not blindly disable irqs
From
On Fri, Mar 6, 2015 at 11:23 AM, Andy Lutomirski <luto@amacapital.net> wrote:
>
> Please don't. IMO it's really nice that we don't use trap gates at
> all on x86_64, and I find the conditional_sti thing much nicer than
> having to audit all of the entry code to see whether it's safe to run
> it with IRQs on.

So I'm not sure I see much difference, but I'd certainly be ok with
just moving the "conditional_sti()" up unconditionally to be the first
thing in do_device_not_available().

The point being that we still *not* just randomly enable interrupts
because we decide that the callers are wrong.

Linus


\
 
 \ /
  Last update: 2015-03-06 23:21    [W:0.297 / U:0.144 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site