lkml.org 
[lkml]   [2015]   [Mar]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH] of: Kconfig: Let OF_UNITTEST depend on "I2C=y" and "I2C_MUX=y"
On Wed, Mar 4, 2015 at 1:58 PM, Pantelis Antoniou
<pantelis.antoniou@konsulko.com> wrote:
> Hi Arnd,
>
>> On Mar 4, 2015, at 21:49 , Arnd Bergmann <arnd@arndb.de> wrote:
>>
>> On Wednesday 04 March 2015 16:04:23 Geert Uytterhoeven wrote:
>>>> - depends on OF_IRQ && OF_EARLY_FLATTREE
>>>> + depends on OF_IRQ && OF_EARLY_FLATTREE && I2C=y && I2C_MUX=y
>>>
>>> ... I think it would be better to replace "#if IS_ENABLED(CONFIG_XXX)" by
>>> "#ifdef CONFIG_XXX" in drivers/of/unittest.c instead.
>>>
>>
>> Agreed. I came across the same bug and came to the same conclusion as you.
>>
>> How about this:
>>
>> 8<----
>> Subject: of: unittest: fix I2C dependency

[...]

>> -#if IS_ENABLED(CONFIG_I2C)
>> +#if IS_BUILTIN(CONFIG_I2C)
>> if (selftest(of_selftest_overlay_i2c_init() == 0, "i2c init failed\n"))
>> goto out;
>>
>>
>
> Patch is fine. I’ll pick it up for the next batch of overlay patches.

Do you have other things that need to go into 4.0? If not I'll pick this up.

Rob


\
 
 \ /
  Last update: 2015-03-05 21:21    [W:0.182 / U:0.308 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site