lkml.org 
[lkml]   [2015]   [Mar]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] Remove redhat'ism from ftrace selftests.
On Thu, Mar 05, 2015 at 08:14:42AM -0700, Shuah Khan wrote:
> On 03/04/2015 06:18 PM, Michael Ellerman wrote:
> > On Wed, 2015-03-04 at 21:44 +0900, Namhyung Kim wrote:
> >>
> >> I think that there's no need to even call true or echo..
> >>
> >> From 0549544e8e982df6478f11e2b4fe419f94c22434 Mon Sep 17 00:00:00 2001
> >> From: Namhyung Kim <namhyung@kernel.org>
> >> Date: Wed, 4 Mar 2015 21:26:38 +0900
> >> Subject: [PATCH] ftracetest: Do not use usleep
> >>
> >> The usleep is only provided on distros from Redhat so running ftracetest
> >> on other distro resulted in failures due to the missing usleep.
> >>
> >> The reason of using [u]sleep in the test was to generate (scheduler)
> >> events. But as we use 'cat trace | grep | wc -l' to read the events,
> >> the command themselves already generate some events before reading the
> >> trace file so no need to call [u]sleep explicitly.
> >>
> >> Reported-by: Michael Ellerman <mpe@ellerman.id.au>
> >> Reported-by: Dave Jones <davej@codemonkey.org.uk>
> >> Signed-off-by: Namhyung Kim <namhyung@kernel.org>
> >
> > Thanks, this is working for me.
> >
> > Tested-by: Michael Ellerman <mpe@ellerman.id.au>
> >
>
> Steve,
>
> Do you want to make a call on which one you want me to take it
> through between these two patches - one from Dave and the other
> from Namhyung Kim.
>
> Please send me the patch I have to pull in. Namhyung Kim's patch
> isn't in the format I can apply and I don't have Dave's patch in
> my inbox.

Removing it entirely sounds like a much better choice, so I'd
wait for Namhyung to resend.

Dave



\
 
 \ /
  Last update: 2015-03-05 16:41    [W:0.036 / U:0.064 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site