lkml.org 
[lkml]   [2015]   [Mar]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH -next] cpuset: initialize cpuset a bit early
From
On Wed, Mar 4, 2015 at 5:09 PM, Zefan Li <lizefan@huawei.com> wrote:
> Now we call ss->bind() in cgroup_init(), so cgroup_init() will
> call cpuset_bind() and then the latter will access top_cpuset's
> cpumask, which is NULL, because cpuset_init() is called after
> cgroup_init()
>
> The simplest fix is to swap cgroup_init() and cpuset_init().
>
> Cc: Vladimir Davydov <vdavydov@parallels.com>
> Fixes: 295458e67284 ("cgroup: call cgroup_subsys->bind on cgroup subsys initialization")
> Reported by: Ming Lei <tom.leiming@gmail.com>
> Signed-off-by: Zefan Li <lizefan@huawei.com>

Looks this patch does fix the boot issue.

> ---
> init/main.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/init/main.c b/init/main.c
> index 61b9937..50d1e95 100644
> --- a/init/main.c
> +++ b/init/main.c
> @@ -667,8 +667,8 @@ asmlinkage __visible void __init start_kernel(void)
> page_writeback_init();
> proc_root_init();
> nsfs_init();
> - cgroup_init();
> cpuset_init();
> + cgroup_init();
> taskstats_init_early();
> delayacct_init();
>
> --
> 1.8.0.2
>


Thanks
Ming Lei


\
 
 \ /
  Last update: 2015-03-04 10:41    [W:0.050 / U:0.636 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site