lkml.org 
[lkml]   [2015]   [Mar]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRE: [PATCH 1/1] subsystem: CPU FREQUENCY DRIVERS- Set cpu_load calculation on current frequency
Date
Hello Viresh,

Thank you for your reply and the information. :)

I have created the patch using the "diff -up" command, I think this way should be used to create patches as mentioned in Documentation/SubmittingPatches..

Could you please help me to know whether any kernel release using interactive governor ? or any way to share the patch the same in any kernel release.

Otherwise I will share the patch to Android guys.



-----Original Message-----
From: Viresh Kumar [mailto:viresh.kumar@linaro.org]
Sent: 03 March 2015 16:17
To: Rahul Khandelwal (Rahul Khandelwal)
Cc: rjw@rjwysocki.net; akpm@linux-foundation.org; linux-kernel@vger.kernel.org; stable@vger.kernel.org
Subject: Re: [PATCH 1/1] subsystem: CPU FREQUENCY DRIVERS- Set cpu_load calculation on current frequency

Hi Newbie :)

On 3 March 2015 at 12:59, Rahul Khandelwal (Rahul Khandelwal) <Rahul.Khandelwal@spreadtrum.com> wrote:
> From: Rahul Khandelwal <Rahul.khandelwal@spreadtrum.com>
>
>
>
> Explanation: When cpu governor fails to set the freq to target_freq,
> the cpu_load calculation is incorrect which is calculating on target_freq.
>
> The cpu_load should be calculated on the pcpu->policy->cur not on the
> target_freq, the cpu delta_time and delta_idle is calculated on
> current freq.
>
>
>
> Signed-off-by: Rahul Khandelwal <Rahul.khandelwal@spreadtrum.com>
>

Your company probably uses Microsoft exchange server (All do) and that corrupts these mails badly.. Over that I don't know what tool you used to send the patch as it doesn't look like 'git' for sure.. But that's not really a problem if you do it correctly..

>
> --- kernel/drivers/cpufreq/cpufreq_interactive.c.orig 2015-03-03
> 12:22:39.070543314 +0530

.orig ??

> +++ kernel/drivers/cpufreq/cpufreq_interactive.c 2015-03-03
> 12:22:36.210543640 +0530

And that too on interactive governor. Before sending patches to Linux kernel, go through the rules please. Documentation/SubmittingPatches..

If you have gone through that it would have been nicer, anyway lets proceed.
You haven't rebased this on any kernel or rc release of official Linux kernel, but on some release on Android.

Android is kept separately and interactive governor is not part of mainline kernel.
If you want this patch to go through, you need to use gerrit to send it to Android guys..
\
 
 \ /
  Last update: 2015-03-05 06:01    [W:0.066 / U:1.196 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site