[lkml]   [2015]   [Mar]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [Qemu-devel] [PATCH v3 01/16] Introduce probe mode for machine type none
On Mon, 2 Mar 2015 16:17:33 -0300
Eduardo Habkost <> wrote:

> > + if (probe_mode) {
> > + /* Use these accelerators in probe mode, tcg should be last */
> > + p = probe_mode_accels;
> I don't fully understand the purpose of this patch yet (I will discuss
> it in a reply to the cover letter). But if you really want -machine none
> to trigger different behavior, why you didn't add a probe_mode field
> to MachineClass, so you can set it in the mahine_none class code?

I initially had this machine attribute but, when I remember correctly, but wasn't able to
communicate it down into the target code. But anyhow, the "mode" is eventually obsolete in light
of the temporarily constructed accelerators.. I will further comment on this as reply to your
comment on the cover letter to keep it in place.


 \ /
  Last update: 2015-03-03 12:01    [W:0.059 / U:1.204 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site