lkml.org 
[lkml]   [2015]   [Mar]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH] x86/asm/entry: Remove user_mode_ignore_vm86()
On Sun, Mar 29, 2015 at 5:13 AM, Borislav Petkov <bp@alien8.de> wrote:
> On Sun, Mar 29, 2015 at 11:02:34AM +0200, Ingo Molnar wrote:
>> So how about doing the patch below?
>>
>> Thanks,
>>
>> Ingo
>>
>> ===================================>
>> From 6677d6f073cfda7f1036eb06d13faaad5c6742cc Mon Sep 17 00:00:00 2001
>> From: Ingo Molnar <mingo@kernel.org>
>> Date: Sun, 29 Mar 2015 09:10:08 +0200
>> Subject: [PATCH] x86/asm/entry: Remove user_mode_ignore_vm86()
>>
>> user_mode_ignore_vm86() can be used instead of user_mode(), in
>> places where we have already done a v8086_mode() security
>> check of ptregs.
>>
>> But doing this check in the wrong place would be a bug that could
>> result in security problems, and also the naming still isn't very clear.
>>
>> Furthermore, it only affects 32-bit kernels, while most development
>> happens on 64-bit kernels.
>>
>> If we replace them with user_mode() checks then the cost is only a
>> very minor increase in various slowpaths:
>>
>> text data bss dec hex filename
>> 10573391 703562 1753042 13029995 c6d26b vmlinux.o.before
>> 10573423 703562 1753042 13030027 c6d28b vmlinux.o.after
>>
>> So lets get rid of this distinction once and for all.
>>
>> Cc: Andy Lutomirski <luto@amacapital.net>
>> Cc: Borislav Petkov <bp@alien8.de>
>> Cc: Denys Vlasenko <dvlasenk@redhat.com>
>> Cc: H. Peter Anvin <hpa@zytor.com>
>> Cc: Linus Torvalds <torvalds@linux-foundation.org>
>> Cc: Oleg Nesterov <oleg@redhat.com>
>> Cc: Thomas Gleixner <tglx@linutronix.de>
>> Signed-off-by: Ingo Molnar <mingo@kernel.org>
>> ---
>> arch/x86/include/asm/ptrace.h | 17 -----------------
>> arch/x86/kernel/cpu/perf_event.c | 2 +-
>> arch/x86/kernel/traps.c | 6 +++---
>> 3 files changed, 4 insertions(+), 21 deletions(-)
>
> I had some doubts about people using user_mode_ignore_vm86() in the
> wrong way and thus introducing sec. bugs.
>
> Since this is only on the slow path, simplifying the code makes sense to
> me.
>
> Acked-by: Borislav Petkov <bp@suse.de>
>

Ditto.

Acked-by: Andy Lutomirski <luto@kernel.org>

> --
> Regards/Gruss,
> Boris.
>
> ECO tip #101: Trim your mails when you reply.
> --



--
Andy Lutomirski
AMA Capital Management, LLC


\
 
 \ /
  Last update: 2015-03-29 16:01    [W:0.046 / U:0.128 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site