lkml.org 
[lkml]   [2015]   [Mar]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 01/86] pci: export pci_ids.h
On Sun, Mar 29, 2015 at 03:37:01PM +0200, Michael S. Tsirkin wrote:
> The macros in pci_ids.h are pretty useful for userspace
> using the pci sysfs interface.
> At the moment userspace is forced to duplicate these macros
> (e.g. QEMU does this), it is better to expose them in
> /usr/include/linux/pci_ids.h so everyone can just include
> this header.
>
> Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
> ---
> include/linux/pci_ids.h | 2998 +-----------------------------------------
> include/uapi/linux/pci_ids.h | 2997 +++++++++++++++++++++++++++++++++++++++++

No, please use the pci ids file from the upstream pci id database
instead. We shouldn't be putting these all in one file, and pulling
them out of drivers isn't ok.

Userspace shouldn't need to know any of these, use libpci.

thanks,

greg k-h


\
 
 \ /
  Last update: 2015-03-29 23:21    [W:0.288 / U:0.792 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site