lkml.org 
[lkml]   [2015]   [Mar]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 36/86] edac/x38_edac: use uapi/linux/pci_ids.h directly
On Sun, Mar 29, 2015 at 03:59:23PM +0200, Borislav Petkov wrote:
> On Sun, Mar 29, 2015 at 03:40:32PM +0200, Michael S. Tsirkin wrote:
> > Header moved from linux/pci_ids.h to uapi/linux/pci_ids.h,
> > use the new header directly so we can drop
> > the wrapper in include/linux/pci_ids.h.
> >
> > Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
> > ---
> > drivers/edac/x38_edac.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/edac/x38_edac.c b/drivers/edac/x38_edac.c
> > index 7c5cdc6..9ce8dd1 100644
> > --- a/drivers/edac/x38_edac.c
> > +++ b/drivers/edac/x38_edac.c
> > @@ -12,7 +12,7 @@
> > #include <linux/module.h>
> > #include <linux/init.h>
> > #include <linux/pci.h>
> > -#include <linux/pci_ids.h>
> > +#include <uapi/linux/pci_ids.h>
> > #include <linux/edac.h>
>
> Can you please merge all edac patches into one?
>
> Provided people are fine with exporting the PCI defines to userspace, of
> course. I personally can't think of a reason why not - those are static
> PCI device numbers and they're in hardware anyway.

OK. I saw they have diff separate entries in maintainers so I wasn't
sure it's a good idea, splitting up patches is always a safe thing to
do.

> --
> Regards/Gruss,
> Boris.
>
> ECO tip #101: Trim your mails when you reply.
> --


\
 
 \ /
  Last update: 2015-03-29 17:01    [W:0.098 / U:8.188 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site