Messages in this thread |  | | Date | Mon, 23 Mar 2015 14:55:19 -0700 | From | Sukadev Bhattiprolu <> | Subject | Re: [8/9] powerpc/hv-24x7: Break up single_24x7_request |
| |
Michael Ellerman [mpe@ellerman.id.au] wrote: | > +static void start_24x7_get_data(struct hv_24x7_request_buffer *request_buffer, | > + struct hv_24x7_data_result_buffer *result_buffer) | > +{ | | Just init_24x7_request() ?
Sure.
| | > + | > + memset(request_buffer, 0, 4096); | > + memset(result_buffer, 0, 4096); | > + | > + request_buffer->interface_version = HV_24X7_IF_VERSION_CURRENT; | > + /* memset above set request_buffer->num_requests to 0 */ | > +} | > + | > +/* | > + * Commit (i.e perform) the H_GET_24x7_DATA hcall using the data collected | > + * by 'start_24x7_get_data()' and 'add_event_to_24x7_request()'. | > + */ | > +static int commit_24x7_get_data(struct hv_24x7_request_buffer *request_buffer, | > + struct hv_24x7_data_result_buffer *result_buffer) | > +{ | | It don't like "commit" that is a loaded term. | | Just make_24x7_request() perhaps?
Sure.
Thanks
Sukadev
|  |