lkml.org 
[lkml]   [2015]   [Mar]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [8/9] powerpc/hv-24x7: Break up single_24x7_request
Michael Ellerman [mpe@ellerman.id.au] wrote:
| > +static void start_24x7_get_data(struct hv_24x7_request_buffer *request_buffer,
| > + struct hv_24x7_data_result_buffer *result_buffer)
| > +{
|
| Just init_24x7_request() ?

Sure.

|
| > +
| > + memset(request_buffer, 0, 4096);
| > + memset(result_buffer, 0, 4096);
| > +
| > + request_buffer->interface_version = HV_24X7_IF_VERSION_CURRENT;
| > + /* memset above set request_buffer->num_requests to 0 */
| > +}
| > +
| > +/*
| > + * Commit (i.e perform) the H_GET_24x7_DATA hcall using the data collected
| > + * by 'start_24x7_get_data()' and 'add_event_to_24x7_request()'.
| > + */
| > +static int commit_24x7_get_data(struct hv_24x7_request_buffer *request_buffer,
| > + struct hv_24x7_data_result_buffer *result_buffer)
| > +{
|
| It don't like "commit" that is a loaded term.
|
| Just make_24x7_request() perhaps?

Sure.

Thanks

Sukadev



\
 
 \ /
  Last update: 2015-03-23 23:01    [W:0.053 / U:1.948 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site