[lkml]   [2015]   [Mar]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH RFC 0/2] x86/fpu: avoid "xstate_fault" in xsave_user/xrestore_user
On Mon, Mar 16, 2015 at 03:57:42PM +0100, Oleg Nesterov wrote:
> Sure, I won't argue if we use the new macros instead. But we already have
> check_insn/user_insn, why not use them?

It certainly is worth a try.

> to me check_insn(ALTERNATIVE_2(...)) looks better. Except we need the
> clobber. It is not easy to read the code like this, imo it would be better
> to avoid copy-and-paste and use the helpers we already have. Just we need
> to improve them.

Yeah, I can't say I'm crazy about those check_insn macros either but
certainly worth a try. Apparently they're the way to go in the fpu code
so let's try to use them...



ECO tip #101: Trim your mails when you reply.

 \ /
  Last update: 2015-03-16 19:21    [W:0.100 / U:0.688 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site