Messages in this thread |  | | Subject | Re: [Qemu-devel] [RFC PATCH v2 04/15] cpu-model/s390: Introduce S390 CPU models | From | Alexander Graf <> | Date | Fri, 20 Feb 2015 16:22:20 +0100 |
| |
> Am 20.02.2015 um 16:00 schrieb Michael Mueller <mimu@linux.vnet.ibm.com>: > > On Fri, 20 Feb 2015 14:54:23 +0100 > Alexander Graf <agraf@suse.de> wrote: > >>> >>> +/* machine related properties */ >>> +typedef struct S390CPUMachineProps { >>> + uint16_t class; /* machine class */ >>> + uint16_t ga; /* availability number of machine */ >>> + uint16_t order; /* order of availability */ >>> +} S390CPUMachineProps; >>> + >>> +/* processor related properties */ >>> +typedef struct S390CPUProcessorProps { >>> + uint16_t gen; /* S390 CMOS generation */ >>> + uint16_t ver; /* version of processor */ >>> + uint32_t id; /* processor identification*/ >>> + uint16_t type; /* machine type */ >>> + uint16_t ibc; /* IBC value */ >>> + uint64_t *fac_list; /* list of facilities */ >> >> Just make this uint64_t fac_list[2]. That way we don't have to track any >> messy allocations. > > It will be something like "uint64_t fac_list[S390_CPU_FAC_LIST_SIZE_UINT64]" and in total 2KB not > just 16 bytes but I will change it.
Why? Do we actually need that many? This is a qemu internal struct.
Alex
|  |