Messages in this thread |  | | From | Rusty Russell <> | Subject | Re: [PATCH 3.2 082/152] virtio: use dev_to_virtio wrapper in virtio | Date | Wed, 18 Feb 2015 15:14:35 +1030 |
| |
Ben Hutchings <ben@decadent.org.uk> writes: > On Tue, 2015-02-17 at 15:56 +1030, Rusty Russell wrote: >> Ben Hutchings <ben@decadent.org.uk> writes: >> > 3.2.67-rc1 review patch. If anyone has any objections, please let me know. >> >> Ben, what are your criteria for putting patches into 3.2? >> >> This patch is a trivial cleanup. It doesn't fix anything, but it does >> add some churn. > > It fixes the definition of dev_to_virtio().
Argh, sorry I should have caught that. The commit message didn't actually mention that it fixed anything (and I took it). :(
>> I can see that 083 and 084 follow this, but 083 needed a backport >> anyway. > > Patch 083 "virtio_pci: defer kfree until release callback" uses > dev_to_virtio(_d) which would expand to a syntax error without this. > >> And it wasn't an issue we saw in Real Life (device removal >> is rare), so it wasn't CC: stable. >> >> 084 was a comment addition. Backporting that just seems weird. > > Nevertheless, it had 'cc: stable' and is obviously harmless.
Ah I see, you stripped the cc:stable in your version. The original did indeed have CC:stable, which is MST's perogative...
Thanks for the explanation, Rusty.
|  |