Messages in this thread |  | | Subject | Re: [PATCH 3.2 082/152] virtio: use dev_to_virtio wrapper in virtio | From | Ben Hutchings <> | Date | Wed, 18 Feb 2015 00:55:42 +0000 |
| |
On Tue, 2015-02-17 at 15:56 +1030, Rusty Russell wrote: > Ben Hutchings <ben@decadent.org.uk> writes: > > 3.2.67-rc1 review patch. If anyone has any objections, please let me know. > > Ben, what are your criteria for putting patches into 3.2? > > This patch is a trivial cleanup. It doesn't fix anything, but it does > add some churn.
It fixes the definition of dev_to_virtio().
> I can see that 083 and 084 follow this, but 083 needed a backport > anyway.
Patch 083 "virtio_pci: defer kfree until release callback" uses dev_to_virtio(_d) which would expand to a syntax error without this.
> And it wasn't an issue we saw in Real Life (device removal > is rare), so it wasn't CC: stable. > > 084 was a comment addition. Backporting that just seems weird.
Nevertheless, it had 'cc: stable' and is obviously harmless.
Ben.
-- Ben Hutchings To err is human; to really foul things up requires a computer. [unhandled content-type:application/pgp-signature] |  |