Messages in this thread |  | | From | Roland Dreier <> | Date | Tue, 17 Feb 2015 10:33:30 -0800 | Subject | Re: [PATCH 1/1] IB/mthca: remove deprecated use of pci api |
| |
On Wed, Feb 4, 2015 at 6:09 AM, Quentin Lambert <lambert.quentin@gmail.com> wrote: > - dev->eq_table.icm_dma = pci_map_page(dev->pdev, dev->eq_table.icm_page, 0, > - PAGE_SIZE, PCI_DMA_BIDIRECTIONAL); > - if (pci_dma_mapping_error(dev->pdev, dev->eq_table.icm_dma)) { > + dev->eq_table.icm_dma = dma_map_page(&dev->pdev->dev, > + dev->eq_table.icm_page, 0, > + PAGE_SIZE, > + (enum dma_data_direction)PCI_DMA_BIDIRECTIONAL);
Surely this can't be right? Shouldn't the direction just change to DMA_BIDIRECTIONAL?
Are we really sweeping through the kernel and getting rid of pci_map_ etc. calls?
If so please respin your semantic patch so that it doesn't add crazy stuff like
(enum dma_data_direction)PCI_DMA_BIDIRECTIONAL
and resend the change.
Thanks, Roland
|  |