Messages in this thread |  | | Date | Tue, 17 Feb 2015 10:56:36 +0300 | From | Vladimir Davydov <> | Subject | Re: [PATCH 1/1] kernel/fork.c: avoid division by zero |
| |
On Mon, Feb 16, 2015 at 07:00:44PM +0100, Heinrich Schuchardt wrote: > diff --git a/kernel/fork.c b/kernel/fork.c > index cf65139..71e2583 100644 > --- a/kernel/fork.c > +++ b/kernel/fork.c > @@ -273,7 +273,8 @@ void __init fork_init(unsigned long mempages) > * value: the thread structures can take up at most half > * of memory. > */ > - max_threads = mempages / (8 * THREAD_SIZE / PAGE_SIZE); > + max_threads = (u64) PAGE_SIZE * (u64) mempages > + / (u64) THREAD_SIZE / 8UL;
This won't compile for a 32 bit arch, will it? Should you use div_u64?
Thanks, Vladimir
|  |