Messages in this thread |  | | Date | Tue, 17 Feb 2015 08:45:53 -0800 | Subject | Re: [PATCH v2] x86, kaslr: propagate base load address calculation | From | Kees Cook <> |
| |
On Tue, Feb 17, 2015 at 4:39 AM, Borislav Petkov <bp@alien8.de> wrote: > On Tue, Feb 17, 2015 at 01:21:20PM +0100, Jiri Kosina wrote: >> I don't have strong feelings either way. It seems slightly nicer >> to have a predictable oops output format no matter the CONFIG_ >> options and command-line contents, but if you feel like seeing the >> 'Kernel offset: 0' in 'nokaslr' and !CONFIG_RANDOMIZE_BASE cases is >> unnecessary noise, feel free to make this change to my patch. > > Well, wouldn't it be wrong to print this line if kaslr is disabled? > Because of the ambiguity in that case: that line could mean either we > randomized to 0 or kaslr is disabled but you can't know that from the > "0" in there, right?
Maybe it should say:
Kernel offset: disabled
for maximum clarity?
-Kees
> > -- > Regards/Gruss, > Boris. > > ECO tip #101: Trim your mails when you reply. > --
-- Kees Cook Chrome OS Security
|  |