[lkml]   [2015]   [Feb]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH 15/45] dm-log-userspace.h: include stdint.h in userspace
On Tuesday 17 February 2015 13:38:06 Alasdair G Kergon wrote:
> On Tue, Feb 17, 2015 at 10:08:56AM +0100, Arnd Bergmann wrote:
> > The normal way to do this in kernel headers is to use linux/types.h
> > but change the data structures to use __u64 instead of uint64_t
> > to avoid the build error.
> That's what happened to dm-ioctl.h.

Ah, indeed. It turns out that it was my own change that did this:

commit 9adfbfb611307060db54691bc7e6d53fdc12312b
Author: Arnd Bergmann <>
Date: Thu Feb 26 00:51:40 2009 +0100

make most exported headers use strict integer types

This takes care of all files that have only a small number
of non-strict integer type uses.

> (Or someone could adjust linux/types.h to include these as standard.)

No, that wouldn't work. The C user space headers are not meant to
be included implicitly by any standard headers, which might pull
in linux/types.h implicitly.

I think it would be best to change all patches in the new series
in the same way for consistency and try to avoid using stdint.h
as much as we can.


 \ /
  Last update: 2015-02-17 15:01    [W:0.077 / U:0.424 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site