[lkml]   [2015]   [Feb]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
Patch in this message
Subject[PATCH 2/4] locks: remove conditional lock release in middle of flock_lock_file
As Linus pointed out:

Say we have an existing flock, and now do a new one that conflicts. I
see what looks like three separate bugs.

- We go through the first loop, find a lock of another type, and
delete it in preparation for replacing it

- we *drop* the lock context spinlock.

- BUG #1? So now there is no lock at all, and somebody can come in
and see that unlocked state. Is that really valid?

- another thread comes in while the first thread dropped the lock
context lock, and wants to add its own lock. It doesn't see the
deleted or pending locks, so it just adds it

- the first thread gets the context spinlock again, and adds the lock
that replaced the original

- BUG #2? So now there are *two* locks on the thing, and the next
time you do an unlock (or when you close the file), it will only
remove/replace the first one.

...remove the "drop the spinlock" code in the middle of this function as
it has always been suspicious.

Reported-by: Linus Torvalds <>
Signed-off-by: Jeff Layton <>
fs/locks.c | 10 ----------
1 file changed, 10 deletions(-)

diff --git a/fs/locks.c b/fs/locks.c
index 7998f670812c..00c105f499a2 100644
--- a/fs/locks.c
+++ b/fs/locks.c
@@ -901,16 +901,6 @@ static int flock_lock_file(struct file *filp, struct file_lock *request)
goto out;

- /*
- * If a higher-priority process was blocked on the old file lock,
- * give it the opportunity to lock the file.
- */
- if (found) {
- spin_unlock(&ctx->flc_lock);
- cond_resched();
- spin_lock(&ctx->flc_lock);
- }
list_for_each_entry(fl, &ctx->flc_flock, fl_list) {
if (!flock_locks_conflict(request, fl))

 \ /
  Last update: 2015-02-17 14:01    [W:0.079 / U:2.292 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site