[lkml]   [2015]   [Feb]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH] media/v4l2-ctrls: Always run s_ctrl on volatile ctrls
Hello Hans

On Tue, Feb 17, 2015 at 1:03 PM, Hans Verkuil <> wrote:
> Should be done after the 'ctrl == NULL' check.

Good catch. Fixed on v2

>> if (ctrl == NULL)
>> continue;
> There is one more change that has to be made: setting a volatile control
> should never generate a V4L2_EVENT_CTRL_CH_VALUE event since that makes
> no sense. The way to prevent that is to ensure that ctrl->has_changed is
> always false for volatile controls. The new_to_cur function looks at that
> field to decide whether to send an event.
> The documentation should also be updated: that of V4L2_CTRL_FLAG_VOLATILE

I can do this also if you want. It has been a while without
contributing to media :)


> Regards,
> Hans

Ricardo Ribalda

 \ /
  Last update: 2015-02-17 13:41    [W:0.061 / U:12.740 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site