[lkml]   [2015]   [Feb]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH V6 03/10] USB: f81232: implement RX bulk-in ep

Greg KH 於 2015/2/17 上午 03:41 寫道:

>> + if (unlikely(data[i+0] & UART_LSR_BRK_ERROR_BITS)) {
> Never use unlikely() unless you can prove that it actually matters if
> you use it. Hint, it's almost impossible to prove, so don't use it, the
> compiler and processor look-ahead is almost smarter than we are.

Thanks for your hint. I'll remove it with next patch.

With Best Regards,
Peter Hung

 \ /
  Last update: 2015-02-17 03:01    [W:0.036 / U:0.908 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site