Messages in this thread |  | | Date | Sun, 15 Feb 2015 10:11:58 +0100 | Subject | Re: [PATCH v3 01/15] h8300: Assembly headers. | From | Geert Uytterhoeven <> |
| |
Hi Sato-san,
On Sun, Feb 15, 2015 at 8:49 AM, Yoshinori Sato <ysato@users.sourceforge.jp> wrote: > --- /dev/null > +++ b/arch/h8300/include/asm/io.h > @@ -0,0 +1,372 @@ > +#ifndef _H8300_IO_H > +#define _H8300_IO_H > + > +#ifdef __KERNEL__ > + > +#include <linux/types.h> > + > +/* > + * These are for ISA/PCI shared memory _only_ and should never be used > + * on any other type of memory, including Zorro memory. They are meant to > + * access the bus in the bus byte order which is little-endian!. > + * > + * readX/writeX() are used to access memory mapped devices. On some > + * architectures the memory mapped IO stuff needs to be accessed > + * differently. On the m68k architecture, we just read/write the > + * memory location directly. > + */ > +/* ++roman: The assignments to temp. vars avoid that gcc sometimes generates > + * two accesses to memory, which may be undesirable for some devices. > + */
While some of the above applies to h8300, I think you should remove the parts that don't apply.
Gr{oetje,eeting}s,
Geert
-- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
|  |