Messages in this thread |  | | Date | Tue, 10 Feb 2015 13:32:17 -0600 | From | Josh Poimboeuf <> | Subject | Re: [RFC PATCH 6/9] livepatch: create per-task consistency model |
| |
On Tue, Feb 10, 2015 at 01:27:59PM -0600, Seth Jennings wrote: > On Mon, Feb 09, 2015 at 11:31:18AM -0600, Josh Poimboeuf wrote: > > diff --git a/kernel/livepatch/transition.h b/kernel/livepatch/transition.h > > new file mode 100644 > > index 0000000..ba9a55c > > --- /dev/null > > +++ b/kernel/livepatch/transition.h > > @@ -0,0 +1,16 @@ > > +#include <linux/livepatch.h> > > + > > +enum { > > + KLP_UNIVERSE_UNDEFINED = -1, > > + KLP_UNIVERSE_OLD, > > + KLP_UNIVERSE_NEW, > > +}; > > + > > +extern struct mutex klp_mutex; > > klp_mutex isn't defined in transition.c. Maybe this extern should be in > the transition.c file or in a core.h file, since core.c provides the > definition?
I originally had the extern in transition.c, but then checkpatch complained so I moved it to transition.h. But yeah, it doesn't really belong there either.
It's kind of ugly for transition.c to be using that mutex anyway. I think it'll be cleaner if I just move the work_fn into core.c.
-- Josh
|  |